[JSB] Fix the behaviour of publishing unavailable state interfaces when they are previously available (backport #1331) #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…en they are previously available (#1331) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## iron #1340 +/- ##
==========================================
- Coverage 65.09% 65.07% -0.02%
==========================================
Files 103 107 +4
Lines 11336 12184 +848
Branches 7159 7495 +336
==========================================
+ Hits 7379 7929 +550
- Misses 1469 1534 +65
- Partials 2488 2721 +233
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While reviewing the Example 13, I came across this situation described in the comment : ros-controls/ros2_control_demos#417 (comment)
After debugging, the resource manager properly sets the state interfaces. However, some internal variables are not properly reset, and this results in the publishing of previously available interfaces.
The proposed fix fixes the issue of properly publishing the state of the known state interfaces alone
This is an automatic backport of pull request #1331 done by Mergify.